This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
Make MultiSigGeneric define virtual emit{EVENT_NAME} functions from which events get emitted
#252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xNeshi
changed the title
MultiSigGeneric define virtual emit{EVENT_NAME} functions from which events get emitted
0xNeshi
commented
Aug 1, 2023
| @@ -29,11 +29,6 @@ contract EndowmentMultiSigEmitter is IEndowmentMultiSigEmitter, Initializable { | |||
| ); | |||
| event TransactionConfirmed(uint256 endowmentId, address owner, uint256 transactionId); | |||
| event TransactionConfirmationRevoked(uint256 endowmentId, address owner, uint256 transactionId); | |||
| event TransactionConfirmationOfFormerOwnerRevoked( | |||
There was a problem hiding this comment.
It is the same as TransactionConfirmationRevoked above and is unused in Subgraph
0xNeshi
commented
Aug 1, 2023
| @@ -62,11 +62,6 @@ contract CharityApplications is MultiSigGeneric, StorageApplications, ICharityAp | |||
| _; | |||
| } | |||
|
|
|||
| // @dev overrides the generic multisig initializer and restricted function | |||
| function initialize(address[] memory, uint256, bool, uint256) public override initializer { | |||
There was a problem hiding this comment.
By making MultiSigGeneric.initialize internal and non-virtual, we make it possible to remove this "not implemented funcs" there were cluttering the contract code only to avoid a compiler error.
Every child of MultiSigGeneric must now implement its own initializer and optionally call super.initialize.
0xNeshi
commented
Aug 1, 2023
| /// @param _approvalsRequired Number of required confirmations. | ||
| /// @param _requireExecution setting for if an explicit execution call is required | ||
| /// @param _transactionExpiry Proposal expiry time in seconds | ||
| function initialize( |
There was a problem hiding this comment.
Just moved it down to "internal functions" section
This reverts commit b44a58e.
stevieraykatz
approved these changes
Aug 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #251
Instructions on making this work
yarnoryarn installto install npm dependencies